-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update docs for Installing and deleting extensions #700
📖 Update docs for Installing and deleting extensions #700
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
815d5e3
to
39994fe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
=======================================
Coverage 64.01% 64.01%
=======================================
Files 22 22
Lines 1370 1370
=======================================
Hits 877 877
Misses 442 442
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* If mulitple catalogs are added to a cluster, you cannot specify a catalog when you install an extension. | ||
* OLM 1.0 requires that all of the extensions have unique bundle and package names for dependency resolution. | ||
|
||
As a result, if two catalogs have an extension with the same name, the installation might fail or lead to an unintended outcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's okay to leave this as is, but IIRC (please correct me if I'm wrong!) the first one found is the one used. It might be worth adding some text about that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a sentence but still kept it sort of hand wavy.
a0dd4f7
to
bee0437
Compare
bee0437
to
92e68aa
Compare
Thank you for the feedback, @everettraven! Suggestions applied. PTAL. |
As a result, if two catalogs have an extension with the same name, the installation might fail or lead to an unintended outcome. | ||
For example, the first extension that matches might install successfully and finish without searching for a match in the second catalog. | ||
|
||
2. Apply the CR the cluster: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be Apply the CR to the cluster
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Fixed in 1feb79a
$ kubectl apply -f <cr_name>.yaml | ||
``` | ||
|
||
??? success |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there ???
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds a toggle to hide the output results once the MD is rendered. You can see it here in the rendered preview, step 2: https://deploy-preview-700--olmv1.netlify.app/tasks/installing-an-extension/
Description
Preview links
Reviewer Checklist